Comments on: Wicket’s RequestLogger

By: Verhage

Verhage — Wed, 23 Sep 2009 20:10:18 +0000

Use additivity=false in your log4j.xml.

Bet you’ve configured some loggers up in the hierarchy along org.apache.wicket.

By: Stefanovich

Stefanovich — Sun, 26 Jul 2009 12:46:18 +0000

Hmm I don’t know. Anyone else?

By: Avner Linder

Avner Linder — Sun, 26 Jul 2009 12:23:32 +0000

Here’s the call-hierarchy again (copied from eclipse), this time more readable (i hope):
logResponseTarget(IRequestTarget) - org.apache.wicket.protocol.http.WebApplication respond(RequestCycle) - org.apache.wicket.request.AbstractRequestCycleProcessor processEventsAndRespond() - org.apache.wicket.RequestCycle step() - org.apache.wicket.RequestCycle respond() - org.apache.wicket.RequestCycle step() - org.apache.wicket.RequestCycle

You can see that respond() is the only caller of logResponseTarget().
You can also see that respond() is being called twice from the step() method, once for each step.

By: Avner Linder

Avner Linder — Sun, 26 Jul 2009 12:16:00 +0000

Hi,
I’ve tried activating the RequestLogger and in many cases duplicate entries appear at the log file for the same request, for example:
2009-07-26 15:00:32,224 INFO - RequestLogger - time=796,event=null,response=[ResourceStreamRequestTarget[resourceStream=org.apache.wicket.markup.html.DynamicWebResource$1@137937,fileName=null],sessionid=11jxsgdnkz6c4,sessionsize=54608,sessionstart=Sun Jul 26 15:00:26 IDT 2009,requests=7,totaltime=4789,activerequests=1,maxmem=66M,total=32M,used=19M 2009-07-26 15:00:32,239 INFO - RequestLogger - time=796,event=null,response=[ResourceStreamRequestTarget[resourceStream=org.apache.wicket.markup.html.DynamicWebResource$1@1e8c1ec,fileName=null],sessionid=11jxsgdnkz6c4,sessionsize=54608,sessionstart=Sun Jul 26 15:00:26 IDT 2009,requests=8,totaltime=5585,activerequests=2,maxmem=66M,total=32M,used=19M

I inspected the call-hierarchy of IRequestLogger.logResponseTarget and found out that it is being called twice by Wicket framework, once for each of the steps: PROCESS_EVENTS and RESPOND

logResponseTarget(IRequestTarget) - org.apache.wicket.protocol.http.WebApplication respond(RequestCycle) - org.apache.wicket.request.AbstractRequestCycleProcessor processEventsAndRespond() - org.apache.wicket.RequestCycle step() - org.apache.wicket.RequestCycle respond() - org.apache.wicket.RequestCycle step() - org.apache.wicket.RequestCycle

any ideas how to prevent the duplicate log entries?

I plan to extend the default RequestLogger, and then I could log events only at one of the steps.
However, the RequestLogger doesn’t have access to the RequestCylce.currentStep

any ideas?

Avner

By: Daan

Daan — Sun, 12 Apr 2009 07:27:56 +0000

Yeah, I have seen the InspectorBug class too. I am building a separate wicket-examples jar (it’s a war now) to check how it works.

- Daan

By: Stefanovich

Stefanovich — Wed, 08 Apr 2009 20:18:37 +0000

Daan,

Have you already seen the InspectorBug class? (wicket.examples.debug package) I couldn’t found a demo if this functionallity but I am very curious what it exactly does.

Regards,
Stefan

By: Stefanovich

Stefanovich — Wed, 08 Apr 2009 20:15:16 +0000

We didn’t plan to do that (yet). Currently we are very busy with a release. I was also thinking to send Martijn a mail. It’s a pitty that it is not open source, because it looked very nice in his presentation.

By: Daan

Daan — Wed, 08 Apr 2009 20:00:25 +0000

Hi Stefan,

I am also experimenting with the Wicket RequestLogger, triggered by the presentation of Martijn on the Wicket Meetup.

A few days ago I mailed Martijn if the code for analyzing this logfile is somewhere online. Unfortunately, this isn’t the case.

Are you guys going to invest time in writing a log file analyzer for Wicket logs? Maybe we can collaborate on that?

Regards,

Daan